-
Notifications
You must be signed in to change notification settings - Fork 100
Browser use refactoring #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser use refactoring #1555
Conversation
13cfd64 to
3a8641d
Compare
Rule 2: Do not overlook possible security vulnerabilitiesDetails: SECURITY RISK - The addition of ignoring key files (*.pem, *.key, *.gpg) in .gitignore could lead to developers accidentally placing sensitive cryptographic materials in the project directory. While it's good that these files won't be committed to the repository, there should be a more secure approach to managing cryptographic materials, such as using a dedicated secrets management system. Affected Code Snippet: Start Line: 172 File Changed:
|
patchwork/app.py
Outdated
| inputs[key] = value | ||
|
|
||
| patchflow_panel = nullcontext() if debug else logger.panel(f"Patchflow {patchflow} inputs") | ||
| patchflow_panel = nullcontext() if plain or not debug else logger.panel(f"Patchflow {patchflow} inputs") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be if debug or plain instead?
PR Checklist
PR Type
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information