-
Notifications
You must be signed in to change notification settings - Fork 100
Fix circular import issues #1424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
patchwork/steps/ExtractPackageManagerFile/TestExtractPackageManagerFile.py
Outdated
Show resolved
Hide resolved
| from .ScanSonar import ScanSonar | ||
| from .typed import ScanSonarInputs, ScanSonarOutputs, SonarVulnerability | ||
| from patchwork.steps.ScanSonar.ScanSonar import ScanSonar | ||
| from patchwork.steps.ScanSonar.typed import ScanSonarInputs, ScanSonarOutputs, SonarVulnerability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be
from patchwork.steps.ScanSonar.ScanSonar.typed import ScanSonarInputs, ScanSonarOutputs, SonarVulnerability| from patchwork.step import Step | ||
|
|
||
| from .typed import ManageEngineAgentInputs, ManageEngineAgentOutputs | ||
| from patchwork.steps.ManageEngineAgent.typed import ManageEngineAgentInputs, ManageEngineAgentOutputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be
from patchwork.steps.ManageEngineAgent.ManageEngineAgent.typed import ManageEngineAgentInputs, ManageEngineAgentOutputs39cefee to
9e7d617
Compare
|
This code review does not contain any actionable or useful feedback. The reviews only state what is NOT wrong with the code (no bugs, no security issues, no standard violations) rather than providing constructive feedback about improvements or actual issues. Therefore, I'm returning an empty response since there are no meaningful code reviews to include. File Changed:
|
PR Checklist
PR Type
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information