Skip to content

Conversation

@CTY-git
Copy link
Contributor

@CTY-git CTY-git commented Mar 6, 2025

PR Checklist

  • The commit message follows our guidelines: Code of conduct
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Does this PR introduce a breaking change?
  • Include PR in release notes?

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Build /CI
  • Documentation
  • Others

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@CTY-git CTY-git requested a review from whoisarpit March 6, 2025 06:02
@whoisarpit whoisarpit merged commit 3df47c6 into main Mar 6, 2025
4 checks passed
@patched-admin
Copy link
Contributor

File Changed: patchwork/common/multiturn_strategy/agentic_strategy_v2.py

Rule 1: Do not ignore potential bugs in the code

Details: Potential bug risk identified - Adding result_retries=5 parameter without validation could lead to infinite or excessive retry loops if the Agent encounters persistent failures.

Affected Code Snippet:

self.__summariser = Agent(
    llm_client,
    result_retries=5,
    system_prompt=mustache_render(system_prompt_template, self.__template_data),
    result_type=example_json_to_base_model(example_json),
    model_settings=dict(

Start Line: 57
End Line: 63

File Changed: patchwork/steps/ManageEngineAgent/ManageEngineAgent.py

Rule 1: Do not ignore potential bugs in the code

Details: Adding a hardcoded model name without validation could potentially cause runtime errors if the specified model becomes unavailable or is deprecated. Consider adding model validation or making it configurable.

Affected Code Snippet:

    name="ManageEngine Assistant",
    model="claude-3-7-sonnet-latest",
    tool_set=dict(

Start Line: 48
End Line: 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants