Skip to content

Conversation

@CTY-git
Copy link
Contributor

@CTY-git CTY-git commented Dec 11, 2024

PR Checklist

  • The commit message follows our guidelines: Code of conduct
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Does this PR introduce a breaking change?
  • Include PR in release notes?

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Build /CI
  • Documentation
  • Others

What is the current behavior?

sigstore action is breaking our release workflow, build artifacts are not uploaded onto github release page.

Issue Number: N/A

What is the new behavior?

Upgrading sigstore action should fix this.

Other information

@CTY-git CTY-git requested a review from jonahdc December 11, 2024 01:52
Copy link
Contributor

@jonahdc jonahdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CTY-git CTY-git merged commit c9b02b0 into main Dec 11, 2024
1 check passed
@CTY-git CTY-git deleted the update-release-workflow branch December 11, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants