Test #64
Closed
Test #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcothenet
commented
Jul 29, 2022
Comment on lines
-1566
to
-1568
| all_params.append("destination_country_code") | ||
| all_params.append("destination_locode") | ||
| all_params.append("destination_postal_code") |
There was a problem hiding this comment.
@holtbp is it possible that you have uncommitted changes to client-code-generation?
pcothenet
commented
Jul 29, 2022
Comment on lines
-1208
to
+1204
| all_params.append("destination_country_code") | ||
| all_params.append("destination_locode") | ||
| all_params.append("destination_postal_code") | ||
| all_params.append("freight_mass_g") | ||
| all_params.append("origin_country_code") | ||
| all_params.append("origin_locode") | ||
| all_params.append("origin_postal_code") | ||
| all_params.append("origin_airport") | ||
| all_params.append("destination_airport") |
There was a problem hiding this comment.
Huh, removing all of the destination/origin fields and putting airport fields for this rail shipping estimate method?
holtbp
reviewed
Jul 29, 2022
| "origin_airport", | ||
| "destination_airport", | ||
| "origin_aiport", | ||
| "destination_aiport", |
There was a problem hiding this comment.
Wait, is this a misspelling? Where is that coming from?
There was a problem hiding this comment.
That's what I'm trying to figure out 🤷 . I only made changes to issued_to and ran the generator.
holtbp
reviewed
Jul 29, 2022
| "amount": "int", | ||
| "unit": "str", | ||
| "issued_to": "V1OrdersIssuedTo", | ||
| "issued_to": "IssuedTo", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
** CHANGEME: What are you changing? **
Why
** CHANGEME: Why are these changes needed? **
SDK Release Checklist