Fix test for new demo data #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcothenet
commented
Jul 6, 2022
| args: ['--config=.flake8'] | ||
| - repo: https://github.com/psf/black | ||
| rev: 21.10b0 | ||
| rev: 22.6.0 |
There was a problem hiding this comment.
Had to update to the latest version due to a bug with Python on M1.
pcothenet
commented
Jul 6, 2022
| self.assertGreater(project.average_price_per_tonne_cents_usd, 0) | ||
| self.assertGreater(project.remaining_mass_g, 0) | ||
| self.assertEqual(project.standard, None) | ||
| self.assertIsInstance(project.standard, object) |
There was a problem hiding this comment.
Shows that having good demo data is a good idea.
rmody3
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the test that started failing because of the update to demo projects Asana
Test update only, not triggering a release
SDK Release Checklist