Skip to content

Clean-up preferences #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2022
Merged

Clean-up preferences #52

merged 2 commits into from
Feb 3, 2022

Conversation

pcothenet
Copy link
Contributor

@pcothenet pcothenet commented Feb 2, 2022 •
edited
Loading

What

  • Wipe out some vestigial files for preferences

Why

  • client-code-generation doesn't automatically delete unused files for us

Notes

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested a review from a team February 2, 2022 23:19
@pcothenet pcothenet merged commit 3c22332 into main Feb 3, 2022
@pcothenet pcothenet deleted the pc/1.17.1 branch February 3, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@zskyfly zskyfly zskyfly approved these changes

@kleinjm kleinjm kleinjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcothenet @zskyfly @kleinjm