Skip to content

Update to make the order allocations array optional #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

Update to make the order allocations array optional #49

merged 1 commit into from
Jan 11, 2022

Conversation

alianam
Copy link
Contributor

@alianam alianam commented Jan 11, 2022 •
edited
Loading

What

  • Changing the order allocations array to be optional

Why

  • Allocations will not always be available for an order

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@alianam alianam requested a review from kleinjm January 11, 2022 15:56
@alianam alianam merged commit 9f6d40b into main Jan 11, 2022
@alianam alianam deleted the am/1.17.0 branch January 11, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kleinjm kleinjm kleinjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alianam @kleinjm