Skip to content

Add crypto params #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2021
Merged

Add crypto params #40

merged 1 commit into from
Sep 10, 2021

Conversation

pcothenet
Copy link
Contributor

@pcothenet pcothenet commented Sep 10, 2021 •
edited
Loading

What

  • Allow crypto estimates via daily balance held

Why

  • More flexible estimates

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

pcothenet
pcothenet commented Sep 10, 2021
View reviewed changes
patch_api/api/estimates_api.py
"year",
"transaction_value_btc_sats",
"timestamp",
"transaction_value_eth_gwei",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we (I) had forgotten a couple parameters. This is why I'm trying to refactor the python SDK generation :)

boconnell2
boconnell2 approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@boconnell2 boconnell2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@pcothenet pcothenet merged commit f02c5e2 into main Sep 10, 2021
@pcothenet pcothenet deleted the pc/btc branch September 10, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@boconnell2 boconnell2 boconnell2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pcothenet @boconnell2