Skip to content

Fix health check #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcothenet merged 1 commit into from
Sep 7, 2021
Merged

Fix health check #43

pcothenet merged 1 commit into from
Sep 7, 2021

Conversation

@pcothenet
Copy link
Contributor

@pcothenet pcothenet commented Sep 7, 2021

What

  • Fix syntax for failure check

Why

** CHANGEME: Why are these changes needed? **

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the package locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested a review from kleinjm September 7, 2021 17:40
@pcothenet pcothenet changed the title Fix healthcheck Fix health check Sep 7, 2021
@kleinjm
Copy link
Contributor

kleinjm commented Sep 7, 2021

I shoulda caught that one. I used the same method here https://github.com/patch-technology/patch/blob/740889668d577725ff231b16fabfa77b39250690/.github/workflows/test.yml#L243

@pcothenet pcothenet merged commit 343d96a into main Sep 7, 2021
@pcothenet pcothenet deleted the pc/hc branch September 7, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kleinjm kleinjm kleinjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pcothenet @kleinjm