feat: qoi wf example #399
feat: qoi wf example #399
Conversation
imMoya
requested review from
apaleyes,
dionhaefner and
xalelax
as code owners
CLA signatures confirmedAll contributors have signed the Contributor License Agreement. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 76.42% 76.45% +0.03%
==========================================
Files 29 29
Lines 3359 3364 +5
Branches 526 526
==========================================
+ Hits 2567 2572 +5
Misses 558 558
Partials 234 234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| config: InputFileReference = Field( | ||
| description="Configuration file" | ||
| ) |
There was a problem hiding this comment.
depedning on the number of variables here, id would be cleaner to write the parameters as a Pydantic model instead of passing a config file. But this is just fine.
There was a problem hiding this comment.
Nevermind, just saw the config file. That seems like the right way to do it!
|
|
||
| data: list[str | Path] = Field( | ||
| description="List of npz files containing point-cloud data, simulation parameters and/or QoIs" | ||
| ) # TODO: Change input type to be list[InputFileReference] (as outputs are inside the qoi_dataset... How can we make this?) |
There was a problem hiding this comment.
I think list[InputFileReference] should work
There was a problem hiding this comment.
Value error, Invalid input file reference: /Users/ignaciomoyaredondo/Documents/git/qoi/qoi_wf/qoi_dataset/outputs/dataset/0.npz. Expected path to be relative to /Users/ignaciomoyaredondo/Documents/git/qoi/qoi_wf/qoi_train/inputs, but got /Users/ignaciomoyaredondo/Documents/git/qoi/qoi_wf/qoi_dataset/outputs/dataset/0.npz. File references have to be relative to --input-path. [type=value_error, input_value='/Users/ignaciomoyaredond...t/outputs/dataset/0.npz', input_type=str]
My inputs live out of the train tesseract (they have been dumped in a folder inside the dataset tesseract)... Is there a way to link both? Should I create a copy inside the train tesseract?
| class OutputSchema(BaseModel): | ||
|
|
||
| qoi : list[Array[(None, ), Float32]] = Field( | ||
| description="QoIs", |
There was a problem hiding this comment.
Probably better to make this a 2D array instead, as this schema is non differentiable.
There was a problem hiding this comment.
but this depends weather we want to have this option in the future, there would also be some changes required to the input schema.
There was a problem hiding this comment.
Fixed it to Array 2D array.
Also dumping it to outputs folder
|
@PasteurBot I have read the CLA Document and I hereby sign the CLA |
Relevant issue or PR
Description of changes
Testing done