-
Notifications
You must be signed in to change notification settings - Fork 4
fix: switch MLflow tests from deprecated file backend to sqlite #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
===========================================
+ Coverage 66.27% 76.35% +10.08%
===========================================
Files 29 29
Lines 3345 3346 +1
Branches 525 525
===========================================
+ Hits 2217 2555 +338
+ Misses 936 558 -378
- Partials 192 233 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Technically this should be fix!: ... (i.e., a breaking change), right @dionhaefner ? |
|
failing CI test will be fixed once #390 is merged |
|
Added detailed tests of sqlite DB file written by MLflow. |
xalelax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Yes it's breaking, let's be sure to highlight that in the release notes. |
Relevant issue or PR
Failing dependency update #386
Description of changes
MLflow deprecates its file backend, which we use in CI testing.
Switching our MLflow CI tests over to supported sqlite backend.
Testing done
CI