Skip to content

fix: allow to set all configs via tesseract build --config-override #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dionhaefner
Copy link
Contributor

Relevant issue or PR

Fixes #232

Description of changes

  • Parse values passed as YAML, so arguments that expect lists (like build_config.package_data) can be set.
  • Some more error checking and helpful error messages for good measure.
  • Add more testing to ensure things work as intended.

Testing done

CI, old and new tests

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.16%. Comparing base (2369668) to head (5d06926).

Files with missing lines Patch % Lines
tesseract_core/sdk/cli.py 45.45% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   70.03%   70.16%   +0.13%     
==========================================
  Files          28       28              
  Lines        3157     3161       +4     
  Branches      505      505              
==========================================
+ Hits         2211     2218       +7     
+ Misses        729      728       -1     
+ Partials      217      215       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnbcoughlin
Copy link
Contributor

Thanks for the quick fix!

@dionhaefner dionhaefner changed the title feat: allow to override more configs fix: allow to set more configs via tesseract build --config-override Jun 27, 2025
@dionhaefner dionhaefner changed the title fix: allow to set more configs via tesseract build --config-override fix: allow to set all configs via tesseract build --config-override Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--config-override parsing is too restrictive
2 participants