-
Notifications
You must be signed in to change notification settings - Fork 2
doc: Add in data assimilation tutorial and refactor example gallery #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 76.21% 76.21%
=======================================
Files 28 28
Lines 3078 3078
Branches 480 480
=======================================
Hits 2346 2346
Misses 519 519
Partials 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5d5e282
to
800ba1e
Compare
9a1170b
to
d5b73da
Compare
Commented in the main body of the PR but I kept the advanced examples on the same page as the building blocks for cohesiveness and also because there is not much content on that front and a singular page would look a bit strange? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but this is such a cool example! gj everyone, but especially @yongquan-qu and @angela-ko !
Co-authored-by: Alessandro Angioi <alessandro.angioi@simulation.science>
Co-authored-by: Alessandro Angioi <alessandro.angioi@simulation.science>
CLA signatures confirmedAll contributors have signed the Contributor License Agreement. |
@PasteurBot I have read the CLA Document and I hereby sign the CLA |
recheck |
why wont the CLA bot pass!! |
recheck |
@yongquan-qu looks like your comment has some extra whitespace. Please copy-paste this verbatim and make sure there's no leading or trailing whitespace:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's iterate a bit more on docs/demo/lorenz_tesseract.md
in a follow-up, but for now this is a great improvement. Thanks all!
@PasteurBot I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of changes
Testing done
Manually regenerated site.. pending ci testing