feat(platforms): adding isDeprecated option to providers, reject verification #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianHymer
force-pushed
the
3034-stamp-deprecation
branch
from
95afddc to
ed9a75d
Compare
lucianHymer
force-pushed
the
3034-stamp-deprecation
branch
from
6d5405b to
9aee965
Compare
nutrina
reviewed
Dec 4, 2024
|
|
||
| // Hide if deprecated and score is 0 | ||
| const checkHiddenByDeprecation = () => | ||
| provider.isDeprecated && parseFloat(stampScores[provider.name] || "0") <= 0; | ||
|
|
There was a problem hiding this comment.
do checkHiddenByCustomization and checkHiddenByDeprecation need to be functions?
Why not compute the boolean value of the flag and store it in flags like isHiddenByCustomization and isHiddenByDeprecation ?
There was a problem hiding this comment.
Just to take advantage of short circuiting, especially if we add more conditions
There was a problem hiding this comment.
The question is what is cheaper?
a. to define a 2 functions on each iteration
b. or use if / else construct instead the short-circuit construct ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3034