Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: need to click next twice and verification error #2670

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

tim-schultz
Copy link
Collaborator

fixes: #2663

Copy link
Collaborator

@nutrina nutrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to work as expected.
After re-verification, the stamp is still highlighted as expired when testing on my local.

nutrina
nutrina previously requested changes Jul 5, 2024
Copy link
Collaborator

@nutrina nutrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment on the code.

@tim-schultz tim-schultz dismissed nutrina’s stale review July 8, 2024 18:24

Error was happening within GenericPlatform and has been resolved. Not in InitiateReverifyStampsButton

@tim-schultz tim-schultz merged commit a81dd69 into main Jul 8, 2024
3 checks passed
await claimCredentials(async () => await Promise.resolve(), [stamp]);
await claimCredentials(
async () => await Promise.resolve(),
() => {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need to provide an error handler here? Fine if not, just wanted to call this out in case it was an oversight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Re-verification Failure Should Display "Not Verified Yet" Instead of "Expired"
3 participants