-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: need to click next twice and verification error #2670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem to work as expected.
After re-verification, the stamp is still highlighted as expired when testing on my local.
aca05a6
to
6aab25c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment on the code.
Error was happening within GenericPlatform and has been resolved. Not in InitiateReverifyStampsButton
d30c2a6
to
9a11e4e
Compare
await claimCredentials(async () => await Promise.resolve(), [stamp]); | ||
await claimCredentials( | ||
async () => await Promise.resolve(), | ||
() => {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not need to provide an error handler here? Fine if not, just wanted to call this out in case it was an oversight!
fixes: #2663