This repository has been archived by the owner on Sep 29, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 19
Add WireGuard RX/TX data statistics #341
Merged
keeshux
merged 12 commits into
passepartoutvpn:master
from
JohnYezub:addWireguardDataCount
Dec 14, 2023
Merged
Add WireGuard RX/TX data statistics #341
keeshux
merged 12 commits into
passepartoutvpn:master
from
JohnYezub:addWireguardDataCount
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add refresh dataCount method in WireGuardTunnelProvider
minor file consolidation
keeshux
suggested changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thanks for your valuable contribution. Please address my concerns about DispatchGroup.
Sources/TunnelKitWireGuardAppExtension/WireGuardTunnelProvider.swift
Outdated
Show resolved
Hide resolved
Sources/TunnelKitWireGuardAppExtension/WireGuardTunnelProvider.swift
Outdated
Show resolved
Hide resolved
keeshux
suggested changes
Dec 12, 2023
Sources/TunnelKitWireGuardAppExtension/WireGuardTunnelProvider.swift
Outdated
Show resolved
Hide resolved
Sources/TunnelKitWireGuardAppExtension/WireGuardTunnelProvider.swift
Outdated
Show resolved
Hide resolved
Sources/TunnelKitWireGuardManager/WireGuard+ProviderConfiguration.swift
Outdated
Show resolved
Hide resolved
Sources/TunnelKitWireGuardManager/WireGuard+ProviderConfiguration.swift
Outdated
Show resolved
Hide resolved
- Reuse existing DataCount - Make stuff private - Shut up linter - Retain newlines
keeshux
approved these changes
Dec 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to follow the OpenVPN logic, based on ProviderConfiguration dataCount I achieved some result to get RX/TX data statistics for WireGuard.
Closes #323