Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic totp support, Export Improvements #43

Merged
merged 12 commits into from
Mar 26, 2024
Merged

Basic totp support, Export Improvements #43

merged 12 commits into from
Mar 26, 2024

Conversation

speatzle
Copy link
Collaborator

@speatzle speatzle commented Mar 21, 2024

Update go-passbolt version to get Basic totp resource support
Deprecate/Rename Old TOTP Flags for Login to distinguish them from new TOTP Resource Flags.
Support Exporting TOTPs
Skip Exporting Resource on Error

Fixes #42

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/passbolt/go-passbolt v0.7.0 <- is this the version with TOTP?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That version has Minimal TOTP Support and the new Secret Schema validation, i cleared up the next hour or 2 to have a look at both go-passbolt and go-passbolt-cli to get Passable TOTP Support.

@speatzle speatzle changed the title Basic totp support Basic totp support, Export Improvements Mar 21, 2024
@speatzle speatzle marked this pull request as ready for review March 26, 2024 10:40
@speatzle speatzle merged commit b3e608e into main Mar 26, 2024
1 of 2 checks passed
@speatzle speatzle deleted the basic-totp-support branch March 26, 2024 10:40
@speatzle speatzle mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export to keepass with user + password + TOTP not possible
3 participants