Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psg 4902 use repo templates #90

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Conversation

jenn-macfarlane
Copy link
Contributor

@jenn-macfarlane jenn-macfarlane commented Oct 23, 2024

What's New?

Uses repo templates to format README, LICENSE, and remove community files in favour of using organization community files.

Screenshots (if appropriate):

CleanShot 2024-10-23 at 14 51 23@2x

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Add any other context or screenshots about the pull request here.

@@ -2,6 +2,16 @@

All notable changes to this project will be documented in this file.

## [1.11.1] - 2024-10-24
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I also need to update version.txt file or will that happen in CI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that file should be updated.

v1.11.1 was already released, but it looks like the changelog was forgotten

the overall changelog should probably be something like

## [1.11.2] - 2024-10-24

### Added

- chore: LICENSE file added

### Changed

- docs: README updated
- docs: update Passage Docs link
- ci: pin gorename to v0.24.0 to avoid conflict with go runtime 1.20.0
- test: fix test user identifier conflict

## [1.11.1] - 2024-07-29

### Changed

- chore(deps): bump github.com/lestrrat-go/jwx from 1.2.26 to 1.2.29 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated - lmk if this looks good

<sub><a href="https://docs.passage.id/home#passage-console">Learn more about Passage Console →</a></sub>
</p>

### Install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these install/import/initialize steps make sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some suggestions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@@ -2,6 +2,16 @@

All notable changes to this project will be documented in this file.

## [1.11.1] - 2024-10-24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that file should be updated.

v1.11.1 was already released, but it looks like the changelog was forgotten

the overall changelog should probably be something like

## [1.11.2] - 2024-10-24

### Added

- chore: LICENSE file added

### Changed

- docs: README updated
- docs: update Passage Docs link
- ci: pin gorename to v0.24.0 to avoid conflict with go runtime 1.20.0
- test: fix test user identifier conflict

## [1.11.1] - 2024-07-29

### Changed

- chore(deps): bump github.com/lestrrat-go/jwx from 1.2.26 to 1.2.29 

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
<sub><a href="https://docs.passage.id/home#passage-console">Learn more about Passage Console →</a></sub>
</p>

### Install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some suggestions

jenn-macfarlane and others added 2 commits October 23, 2024 15:15
Co-authored-by: Chris Tran <ctran88@users.noreply.github.com>
Copy link

sonarcloud bot commented Oct 23, 2024

@jenn-macfarlane jenn-macfarlane merged commit e1b7a15 into main Oct 23, 2024
2 checks passed
@jenn-macfarlane jenn-macfarlane deleted the PSG-4902-use-repo-templates branch October 23, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants