-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Psg 4902 use repo templates #90
Conversation
@@ -2,6 +2,16 @@ | |||
|
|||
All notable changes to this project will be documented in this file. | |||
|
|||
## [1.11.1] - 2024-10-24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I also need to update version.txt
file or will that happen in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that file should be updated.
v1.11.1 was already released, but it looks like the changelog was forgotten
the overall changelog should probably be something like
## [1.11.2] - 2024-10-24
### Added
- chore: LICENSE file added
### Changed
- docs: README updated
- docs: update Passage Docs link
- ci: pin gorename to v0.24.0 to avoid conflict with go runtime 1.20.0
- test: fix test user identifier conflict
## [1.11.1] - 2024-07-29
### Changed
- chore(deps): bump github.com/lestrrat-go/jwx from 1.2.26 to 1.2.29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated - lmk if this looks good
<sub><a href="https://docs.passage.id/home#passage-console">Learn more about Passage Console →</a></sub> | ||
</p> | ||
|
||
### Install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these install/import/initialize steps make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
@@ -2,6 +2,16 @@ | |||
|
|||
All notable changes to this project will be documented in this file. | |||
|
|||
## [1.11.1] - 2024-10-24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that file should be updated.
v1.11.1 was already released, but it looks like the changelog was forgotten
the overall changelog should probably be something like
## [1.11.2] - 2024-10-24
### Added
- chore: LICENSE file added
### Changed
- docs: README updated
- docs: update Passage Docs link
- ci: pin gorename to v0.24.0 to avoid conflict with go runtime 1.20.0
- test: fix test user identifier conflict
## [1.11.1] - 2024-07-29
### Changed
- chore(deps): bump github.com/lestrrat-go/jwx from 1.2.26 to 1.2.29
<sub><a href="https://docs.passage.id/home#passage-console">Learn more about Passage Console →</a></sub> | ||
</p> | ||
|
||
### Install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some suggestions
Co-authored-by: Chris Tran <ctran88@users.noreply.github.com>
Quality Gate passedIssues Measures |
What's New?
Uses repo templates to format README, LICENSE, and remove community files in favour of using organization community files.
Screenshots (if appropriate):
Type of change
Checklist:
Additional context
Add any other context or screenshots about the pull request here.