fix: empty user status not handled

passageidentity · May 6, 2024 · 2434541 · 2434541
1 parent bb498ef
commit 2434541
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/passage/fix_generated_code.py b/passage/fix_generated_code.py
@@ -20,8 +20,26 @@
   # User model requires `webauthn_types` property, but webauthn start returns user WITHOUT it, so we must make it optional.
   (
     './generated/src/main/kotlin/id/passage/android/model/User.kt',
-    'val webauthnTypes: kotlin.collections.List<WebAuthnType>',
-    'val webauthnTypes: kotlin.collections.List<WebAuthnType>?'
+    '''val webauthnTypes: kotlin.collections.List<WebAuthnType>
+
+''',
+    '''val webauthnTypes: kotlin.collections.List<WebAuthnType>?
+
+'''
+  ),
+
+  # Some endpoints return a user with a status set to "". This is incompatible with the spec, so we have to add the statusUnavailable option.
+  (
+    './generated/src/main/kotlin/id/passage/android/model/UserStatus.kt',
+    '''@Json(name = "pending")
+    pending("pending");
+''',
+    '''@Json(name = "pending")
+    pending("pending"),
+
+    @Json(name = "")
+    statusUnavailable("");
+    '''
   ),
 
   # Add more replacements here as needed

diff --git a/passage/generated/src/main/kotlin/id/passage/android/model/UserStatus.kt b/passage/generated/src/main/kotlin/id/passage/android/model/UserStatus.kt
@@ -33,8 +33,11 @@ enum class UserStatus(val value: kotlin.String) {
     inactive("inactive"),
 
     @Json(name = "pending")
-    pending("pending");
+    pending("pending"),
 
+    @Json(name = "")
+    statusUnavailable("");
+
     /**
      * Override toString() to avoid using the enum variable name as the value, and instead use
      * the actual value defined in the API spec file.