(BSR) docs(pr): upgrade PR template #6963
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,41 @@ | ||
| # Issue Description / Feature | ||
|
|
||
| Describe here the context of the PR: the issue fixed, the feature added, and why these changes are necessary. | ||
|
|
||
| Link to JIRA ticket: <https://passculture.atlassian.net/browse/PC-XXXXX> | ||
|
|
||
| ## Potential impact | ||
|
|
||
| Describe the potential impact of this PR on other parts of the application. | ||
|
|
||
|
|
||
| ## Flakiness | ||
|
|
||
| If I had to re-run tests in the CI due to flakiness, I add the incident [on Notion][2] | ||
|
|
||
| ## Checklist | ||
|
|
||
| - [ ] I have verified that my feature works on **web**. | ||
| - [ ] I have verified that my feature works on **mobile** (depending on relevance: real or virtual devices). | ||
| - [ ] I have **rebased my branch** onto the latest version of `master` to avoid conflicts and ensure a clean history. | ||
| - [ ] I have **squashed my commits** into logical units, if necessary, to keep the commit history clean. | ||
|
There was a problem hiding this comment. on a un hook qui rebase avant de push on squash les PR, donc rebase ou non la branche ne changera pas l'historique GitHub empèche de merger s'il y a des conflits |
||
| - [ ] I have ensured that my commits have **clear and concise messages describing what has been changed**. | ||
| - [ ] I have written **unit tests** for the feature (including separate tests for web if the implementation differs). | ||
|
Comment on lines
+20
to
+21
There was a problem hiding this comment. les PR sont squashées, l'historique des commits n'est pas conservé |
||
| - [ ] I have added **screenshots** for UI tickets or removed the screenshot section if no UI changes were made. | ||
| - [ ] If my PR fixes a bug, I have added the link to the "résolution de problème sur le bug" [on Notion][1] | ||
| - [ ] I have updated the **documentation** (README, [Notion Fonctionnalités][3], [Cookies/RGPD][4]) if necessary. | ||
|
|
||
| ## Screenshots | ||
|
|
||
| Add screenshots for UI changes here (or delete this section if not applicable or no UI change). | ||
|
|
||
| | Platform | Mockup/Before | After | | ||
| | :--------------: | :-----------: | :---: | | ||
| | iOS | | | | ||
| | Android | | | | ||
| | Phone - Chrome | | | | ||
| | Desktop - Chrome | | | | ||
|
|
||
| [1]: https://www.notion.so/passcultureapp/R-solution-de-probl-mes-sur-les-bugs-5dd6df8f6a754e6887066cf613467d0a | ||
| [2]: https://www.notion.so/passcultureapp/cb45383351b44723a6f2d9e1481ad6bb?v=10fe47258701423985aa7d25bb04cfee&pvs=4 | ||
| [3]: https://www.notion.so/passcultureapp/ee41fd44e01d40a5ba059d8782644c8f?v=2942b814969d4fae965a7d63bf5c502e&pvs=18 | ||
| [4]: https://www.notion.so/passcultureapp/Cookies-et-autres-traceurs-ac25e6cc954549309889fcca75dc1ce8 | ||
|
There was a problem hiding this comment. je pense que cette page n'est plus utilisée historiquement c'était les PM qui documentaient les fonctionnalités dans Notion |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, c'est bien pour les projets open source où on reçoit des contributions externes non prévues
dans notre cas, tout nos changements sont initiés par un ticket jira
se poser la question au moment de la PR est trop tard
il faudrait que cette question soit répondue avant de commencer le ticket