Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-31397) chore(deps): bump yarn and modify types in ts config #6796

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

NolwenMajorFrances
Copy link
Contributor

@NolwenMajorFrances NolwenMajorFrances commented Aug 21, 2024

@NolwenMajorFrances NolwenMajorFrances changed the title PC-31397 bump jest and modify types in ts config (PC-31397) chore(deps): bump yarn and modify types in ts config Aug 21, 2024
@thconte thconte force-pushed the add-yarn branch 24 times, most recently from 78c4d89 to 45bbaf8 Compare August 29, 2024 07:33
@thconte thconte force-pushed the add-yarn branch 2 times, most recently from c031fbe to 420958d Compare September 18, 2024 10:28
Copy link

github-actions bot commented Sep 18, 2024

Performance Comparison Report

  • Current: HEAD (bccca9f) - 2024-09-18 12:54:22Z
  • Baseline: master (4f0f481)

Significant Changes To Duration

Name Type Duration Count
Search Landing Page - Performance test for Search Landing page render 14.4 ms → 9.3 ms (-5.1 ms, -35.4%) 🟢🟢 5 → 5
Performance test for EndedBookings page render 34.1 ms → 26.8 ms (-7.3 ms, -21.4%) 🟢 7 → 7
Performance test for Bookings page render 44.4 ms → 34.2 ms (-10.2 ms, -23.0%) 🟢 7 → 7
Performance test for Favorites page render 64.8 ms → 53.6 ms (-11.2 ms, -17.3%) 🟢 6 → 6
Performance test for Offer page render 173.0 ms → 136.2 ms (-36.8 ms, -21.3%) 🟢 4 → 4
Show details
Name Type Duration Count
Search Landing Page - Performance test for Search Landing page render Baseline
Mean: 14.4 ms
Stdev: 1.2 ms (8.2%)
Runs: 16 15 15 15 15 15 14 14 13 12

Current
Mean: 9.3 ms
Stdev: 0.9 ms (10.2%)
Runs: 9 8 9 10 9 9 10 11 10 8
Warmup runs: 16
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
Performance test for EndedBookings page render Baseline
Mean: 34.1 ms
Stdev: 1.9 ms (5.4%)
Runs: 37 36 36 34 34 34 34 33 32 31

Current
Mean: 26.8 ms
Stdev: 1.2 ms (4.6%)
Runs: 27 26 27 27 29 25 27 27 28 25
Warmup runs: 59
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Redundant updates: 17 (1, 2, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 15, 16, 17, 18, 19)
Performance test for Bookings page render Baseline
Mean: 44.4 ms
Stdev: 2.3 ms (5.1%)
Runs: 47 47 46 46 46 44 43 42 42 41

Current
Mean: 34.2 ms
Stdev: 1.9 ms (5.5%)
Runs: 36 35 35 36 33 31 33 37 33 33
Warmup runs: 111
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Redundant updates: 16 (1, 2, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17)
Performance test for Favorites page render Baseline
Mean: 64.8 ms
Stdev: 4.1 ms (6.3%)
Runs: 71 69 68 67 65 64 63 62 62 57

Current
Mean: 53.6 ms
Stdev: 1.4 ms (2.7%)
Runs: 53 53 52 54 54 56 55 55 52 52
Warmup runs: 316
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Render issues:
- Redundant updates: 23 (1, 2, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 19, 20, 21, 22, 23, 24, 25, 26)
Performance test for Offer page render Baseline
Mean: 173.0 ms
Stdev: 8.6 ms (5.0%)
Runs: 188 181 180 179 173 170 166 166 165 162

Current
Mean: 136.2 ms
Stdev: 7.6 ms (5.6%)
Runs: 153 142 132 138 138 133 134 132 124 136
Warmup runs: 228
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Redundant updates: 4 (1, 2, 6, 7)

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Performance test for Profile page render 6.3 ms → 3.7 ms (-2.6 ms, -41.3%) 🟢 5 → 5
Search Results - Performance test for Search Results page render 13.5 ms → 10.1 ms (-3.4 ms, -25.2%) 🟢 5 → 5
Performance test for Venue page render 2.4 ms → 0.4 ms (-2.0 ms, -83.3%) 🟢 1 → 1
Show details
Name Type Duration Count
Performance test for Profile page render Baseline
Mean: 6.3 ms
Stdev: 0.8 ms (13.1%)
Runs: 8 7 7 6 6 6 6 6 6 5

Current
Mean: 3.7 ms
Stdev: 1.1 ms (28.6%)
Runs: 4 5 3 3 3 4 5 5 2 3
Warmup runs: 8
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Redundant updates: 10 (1, 2, 4, 5, 6, 7, 8, 9, 10, 11)
Search Results - Performance test for Search Results page render Baseline
Mean: 13.5 ms
Stdev: 1.6 ms (12.2%)
Runs: 16 15 15 14 14 14 12 12 12 11

Current
Mean: 10.1 ms
Stdev: 1.2 ms (11.9%)
Runs: 12 10 9 10 11 11 8 10 11 9
Warmup runs: 13
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
Performance test for Venue page render Baseline
Mean: 2.4 ms
Stdev: 0.5 ms (21.5%)
Runs: 3 3 3 3 2 2 2 2 2 2

Current
Mean: 0.4 ms
Stdev: 0.5 ms (129.1%)
Runs: 0 0 0 1 0 0 0 1 1 1
Warmup runs: 1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
Performance test for Offer page - 4 (1, 2, 6, 7) 🔴
Performance test for Favorites page - 23 (1, 2, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 19, 20, 21, 22, 23, 24, 25, 26) 🔴
Performance test for Bookings page - 16 (1, 2, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17) 🔴
Performance test for EndedBookings page - 17 (1, 2, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 15, 16, 17, 18, 19) 🔴
Search Results - Performance test for Search Results page 2 🔴 2 (3, 4) 🔴
Search Landing Page - Performance test for Search Landing page 2 🔴 2 (3, 4) 🔴
Performance test for Profile page - 10 (1, 2, 4, 5, 6, 7, 8, 9, 10, 11) 🔴

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 0dc7d00

Copy link

sonarcloud bot commented Sep 18, 2024

Copy link

sonarcloud bot commented Sep 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants