(BSR) ci(env): check variables in env files #6318
+81
−49
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import { config } from 'dotenv' | ||
|
|
||
| function loadEnvVariables(filePath: string) { | ||
| const { parsed, error } = config({ path: filePath }) | ||
| if (error) { | ||
| throw error | ||
| } | ||
| if (!parsed) { | ||
| throw new Error(`No variables found in ${filePath}`) | ||
| } | ||
|
|
||
| return Object.keys(parsed) | ||
| } | ||
|
|
||
| function compareEnvFiles(envFiles: string[]) { | ||
| const envData: Record<string, string[]> = {} | ||
| envFiles.forEach((file) => { | ||
| envData[file] = loadEnvVariables(file) | ||
| }) | ||
|
|
||
| const allKeys = new Set<string>() | ||
| for (const data of Object.values(envData)) { | ||
| for (const key of data) { | ||
| allKeys.add(key) | ||
| } | ||
| } | ||
|
|
||
| const missing: Record<string, string[]> = {} | ||
| for (const [file, data] of Object.entries(envData)) { | ||
| missing[file] = Array.from(allKeys).filter((x) => !data.includes(x)) | ||
| } | ||
|
Comment on lines
+28
to
+31
There was a problem hiding this comment. Les Set ont des méthodes pour les comparer https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set#set_composition j'ai l'impression que A.symmetricDifference(B) répondrait au besoin There was a problem hiding this comment. Ça risque d'être compliqué : c'est pas dispo en Node ! |
||
|
|
||
| return missing | ||
| } | ||
|
|
||
| describe('.env files', () => { | ||
| const envFiles = ['.env.testing', '.env.staging', '.env.integration', '.env.production'] | ||
|
|
||
| test('all variables should be present in all .env files', () => { | ||
| const missingVariables = compareEnvFiles(envFiles) | ||
| for (const [file, variables] of Object.entries(missingVariables)) { | ||
| if (variables.length > 0) { | ||
| throw new Error(`Missing variables in ${file}: ${variables.join(', ')}`) | ||
| } | ||
| } | ||
|
|
||
| expect(true).toBe(true) // Pass if no error is thrown | ||
| }) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j'ai l'impression qu'il pourrait etre intéressant d'avoir un
Seten valeurThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si on avait la méthode Set.union et Set.symetricDifference, carrément, mais ce n'est pas le cas en NodeJS, donc c'est + simple avec un array :/