Merged
Conversation
pascalpp
commented
Jan 29, 2021
pascalpp
commented
Jan 29, 2021
pascalpp
commented
Jan 30, 2021
| <connections> | ||
| <action selector="toggleGroupRulers:" target="Voe-Tx-rLC" id="RkN-cz-hMe"/> | ||
| </connections> | ||
| </menuItem> |
Owner
Author
There was a problem hiding this comment.
this was a weird stray menuitem that somehow got added outside the menu, not visible in the app. A duplicate of the existing Group Rulers menu item.
fixes a bug where the unit label would disappear when dragging the other ruler
lanurmi
reviewed
Jan 30, 2021
Owner
Author
|
@jeff-h Do you have some time to try out this PR before I merge it out? |
Owner
Author
|
@carlfriess Do you have some time to try out this PR before I merge it out? |
carlfriess
reviewed
Feb 3, 2021
Contributor
|
Looks good to me! :) |
Co-authored-by: Carl Friess <carl.friess@me.com>
Collaborator
|
Hey, sorry I haven't had a chance to look at anything properly recently — just been flat out with other work. Appreciate all your work though! These latest features are awesome. |
Owner
Author
|
@jeff-h no worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPX,MM, andIN