Skip to content

Add units to rulers (mm and in)#89

Merged
pascalpp merged 7 commits intopascalpp:masterfrom
carlfriess:units
Jan 25, 2021
Merged

Add units to rulers (mm and in)#89
pascalpp merged 7 commits intopascalpp:masterfrom
carlfriess:units

Conversation

@carlfriess
Copy link
Contributor

@carlfriess carlfriess commented Dec 2, 2020

Adds support for millimetres and inches via options in the menubar. See screenshots below. Uses the Core Graphics API to determine the physical size of the screen and calculate the DPI.

Resolves #68.

image

image

image

@pascalpp
Copy link
Owner

pascalpp commented Dec 2, 2020

@carlfriess thanks for this. I've been away from Free Ruler dev for a bit but i'll give this a tryout this weekend.

@jeff-h
Copy link
Collaborator

jeff-h commented Dec 2, 2020

@carlfriess Quick question — I skimmed your new code but didn't see anything checking for when you move the rulers to a new screen. Is that handled?

@carlfriess
Copy link
Contributor Author

Yup, it checks which NSScreen to use on every draw() call using the computed property here.

@jeff-h
Copy link
Collaborator

jeff-h commented Dec 2, 2020

Nicely done!

@pascalpp pascalpp merged commit c36121b into pascalpp:master Jan 25, 2021
@pascalpp
Copy link
Owner

@carlfriess Sorry this took me so long to test out. Works great, thank you so much! I'll try to push a new release tomorrow.

@fabulousrice
Copy link

I've just downloaded version 2.0.3 and still do not see the "Units" menu. Where are the options to change unit? Running Catalina.

https://imgur.com/HISabE4

@pascalpp
Copy link
Owner

@fabulousrice I have to push a new release with these changes. Working on it.

@fabulousrice
Copy link

Ok I understand. Since the Github feedback requests for this feature have been closed, I assumed that they were fixed in the available build (otherwise people will ask for them again...) it was unclear since there are screenshots in this conversation that show a different behavior. Thanks for your work

@pascalpp
Copy link
Owner

This is now available in https://github.com/pascalpp/FreeRuler/releases/tag/v2.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for other units (inches, picas, cm)

4 participants