Skip to content

add Chinese Translation#114

Merged
pascalpp merged 3 commits intopascalpp:masterfrom
pluwen:master
Mar 23, 2023
Merged

add Chinese Translation#114
pascalpp merged 3 commits intopascalpp:masterfrom
pluwen:master

Conversation

@pluwen
Copy link
Contributor

@pluwen pluwen commented Mar 23, 2023

Thank you for the author's hard work, which allows us to use such a useful screen ruler software. I have provided a Simplified Chinese translation, hoping to help Chinese-speaking users.

@pascalpp
Copy link
Owner

@pluwen Thanks for this PR. I'm trying to run it locally, but not able to see the localization in the running app. I set my primary language to Chinese, Simplified and restarted my Mac, but when I build and run I still see English menu labels.

image

image

image

I noticed that in Xcode, I don't see the new localization alongside the German and Finnish localizations.
image

Is there something else that needs to be done to make this localization show up alongside the others?

@pluwen
Copy link
Contributor Author

pluwen commented Mar 23, 2023

I modified the project information of Xcode, you can try it again.

@pascalpp
Copy link
Owner

Sweet, it's working now.
image

Now I just have to remember how to do a release : )

@pascalpp pascalpp merged commit 8dfa623 into pascalpp:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants