Skip to content

Conversation

@pascalduez
Copy link
Owner

@pascalduez pascalduez commented Feb 8, 2024

See #7, #13

Just checking what it takes, whether it make sense or not.

While this "solves" the issue with classes used with composes. This does not solve the one with @value.

@value camelCase: green;
a { color: camelCase } /* error */

Since @value can be used in a wide range of properties, we don't have much solutions here.

Also we can see that disabling selector-class-pattern was necessary locally.
The CSS modules spec don't enforce a particular case, so this config won't disable selector-class-pattern. It's out of scope.

The whole benefit of this change is quite debatable, some per projects overrides will always be needed.
One would still need to:

  • disable selector-class-pattern locally
  • change case for @value or build a unmaintainable list of ignored properties

@Danil42Russia
Copy link

Hello!
What is currently preventing this PR from being merged into master? A very necessary fix, now I have to add this fix to my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants