This repository was archived by the owner on Feb 14, 2019. It is now read-only.
Prod fixes #44
Merged
Prod fixes #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idokleinman
suggested changes
Apr 21, 2017
Contributor
idokleinman
left a comment
idokleinman
left a comment
There was a problem hiding this comment.
I am thinking lib should check - if organization=true and productMode=false - if so then error out and crash the app. Also if product is true and productId not set (0)... Is there a graceful way to do it in Android?
| if (!all(signUpInfo.getUsername(), signUpInfo.getPassword(), productId)) { | ||
| throw new IllegalArgumentException( | ||
| "Email, password, and organization must all be specified"); | ||
| "Email, password, and product slug must all be specified"); |
Contributor
Author
There was a problem hiding this comment.
True, changed that now.
Contributor
Author
|
Both organization=true and productMode=false would be in setup library, so I'll check if there's graceful way to crash once I update it. Initially I'd say it's possible as we're obviously accessing those fields during setup. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding organization endpoints back with deprecation message on use.