Skip to content

Abuse of PR: Preview article fixing keypad #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Abuse of PR: Preview article fixing keypad #340

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
126a663
Writeup: Detailed rationale documenting a fix.
0-8-15 Sep 28, 2020
891689f
Article: Locating the issue.
0-8-15 Sep 28, 2020
35ff991
Article: Taste or Rationale
0-8-15 Sep 28, 2020
44fd380
Footnote: See SRFI-110 as example of a reader modification.
0-8-15 Sep 28, 2020
88e9dbc
Article: Code spot review.
0-8-15 Sep 28, 2020
c49e1fd
Article: hit the re-format key
0-8-15 Sep 28, 2020
04fb775
Article: Summary Of First Assessment
0-8-15 Sep 28, 2020
9fbebf7
Article: To Be Continued. Good Night.
0-8-15 Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 29 additions & 13 deletions modules/ln_glgui/keypad.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,20 +196,36 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
))

(define (keypad:lookup mx my x y w h pad)
(let* ((ncols (flo (length (car pad))))
(nrows (flo (length pad)))
(wchar (/ w ncols))
(hchar (/ h nrows))
(mn (fix (- nrows 1 (fix (/ (- my y) hchar))))))
;; FIXME: unconfirmed: errors out in list-ref.
;; FIXME: COMPLEXITY: O(n^2) - use of list-ref in loop
(let* ((ncols
;; ??? what if that's not the longest line?
;;
;; refs: {wchar} -- `flo` in order to make `wchar` a FP?
(flo (length (car pad))))
(nrows
;; refs: {hchar,nm} -- `flo` in order to make `hchar` a FP?
;;
;; what about `nrows` in commented-out code?
(flo (length pad)))
(wchar (/ w ncols)) ;; inexact, with of character fields
(hchar (/ h nrows)) ;; inexact, height of character fields
(mn ;; ??? XXX row index
(fix (- nrows 1 (fix (/ (- my y) hchar))))))
(if (and (> my y) (< my (+ y h))) ;; (and (> mn -1) (< mn nrows))
(let* ((units (keypad:rowwidth (list-ref pad mn)))
(padx (/ (- w (* units wchar)) 2.)))
(let loop ((xx (+ x padx))(data (list-ref pad mn)))
(if (= (length data) 0) #f
(let ((keyw (* wchar (keypad:keywidth (car data)))))
(if (and (> mx xx) (< mx (+ xx keyw))) (car data)
(loop (+ xx keyw) (cdr data)))))))
#f)))
(let* ((units
;; TBD: COMPLEXITY: O(n) - use of list-ref
;; FIXME: COMPLEXITY: O(n^2) - use of keypad:rowwidth on O(n) value
(keypad:rowwidth (list-ref pad mn)))
(padx (/ (- w (* units wchar)) 2.)))
(let loop ((xx (+ x padx)) (data (list-ref pad mn)))
(if (= (length data) 0) ;; FIXME: COMPLEXITY: O(n^2) - use of `length` in loop
#f
;; FIXME: COMPLEXITY: O(n^2) - use of length within `keypad:keywidth`
(let ((keyw (* wchar (keypad:keywidth (car data)))))
(if (and (> mx xx) (< mx (+ xx keyw))) (car data)
(loop (+ xx keyw) (cdr data)))))))
#f)))

(define (glgui:keypad-input g wgt type mx my)
(let* ((x (glgui-widget-get-dyn g wgt 'x))
Expand Down