Skip to content

fix: bug introduced in #1136 #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2025
Merged

fix: bug introduced in #1136 #1151

merged 2 commits into from
Feb 1, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 31, 2025 •
edited
Loading

Fixes #1149.

Description

Pull from ingestors for only user-defined streams, not internal

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

fix: bug introduced in parseablehq#1136
4f930ef 
Signed-off-by: Devdutt Shenoi <devdutt@parseable.com>
nikhilsinhaparseable
nikhilsinhaparseable approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 82574c0 into parseablehq:main Feb 1, 2025
11 checks passed
@de-sh de-sh deleted the patch-1 branch February 1, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of staging files reported by API is incorrect
3 participants
@de-sh @nikhilsinhaparseable @nitisht