Skip to content

fix: limit JSON payload size to 10MB #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 24, 2025

Fixes #XXXX.

Description

Since #1100 we are using the Json extractor, which uses JsonConfig, not PayloadConfig

Testing

Send payload of size 5MB to the restricted endpoints, e.g. /api/v1/ingest


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 24, 2025

Pull Request Test Coverage Report for Build 12947359857

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 12.786%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/modal/ingest_server.rs 0 1 0.0%
src/handlers/http/modal/query_server.rs 0 1 0.0%
src/handlers/http/modal/server.rs 0 5 0.0%
Totals Coverage Status
Change from base Build 12943351293: 0.0%
Covered Lines: 2446
Relevant Lines: 19131

💛 - Coveralls

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit 5a39e22 into parseablehq:main Jan 24, 2025
11 checks passed
@de-sh de-sh deleted the fix-json branch January 24, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants