-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
refactor: Upgrade bcryptjs from 2.4.3 to 3.0.2 #9677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Snyk has created this PR to upgrade bcryptjs from 2.4.3 to 3.0.2. See this package in npm: bcryptjs See this project in Snyk: https://app.snyk.io/org/acinader/project/21343059-02d9-4182-87d7-718a44b181ef?utm_source=github&utm_medium=referral&page=upgrade-pr
I will reformat the title to use the proper commit message syntax. |
🚀 Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9677 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 187 187
Lines 15066 15066
=======================================
Hits 14035 14035
Misses 1031 1031 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎉 This change has been released in version 8.1.1-alpha.1 |
🎉 This change has been released in version 8.2.0 |
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe only change made was updating the version of the "bcryptjs" dependency in the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Snyk has created this PR to upgrade bcryptjs from 2.4.3 to 3.0.2.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 3 versions ahead of your current version.
The recommended version was released a month ago.
Release notes
Package name: bcryptjs
Bug fixes
Bug fixes
Breaking changes
The project now exports an ECMAScript module by default, albeit with an UMD fallback, ships with types, the dist/ directory no longer exists in version control, and Closure Compiler externs have been removed.
This library was not affected by the bug that led to incrementing the bcrypt version from 2a to 2b, but nowadays most implementations use 2b, including the native bcrypt binding, so this change aligns with them. Existing hashes will continue to work, but test logic that generates hashes and compares them literally might need to be updated to account for the new default.
Features
Other
Backlog from v2
The npm package does not need externs as it is needed only for closure compiler. Added it in .npmignore since bcryptjs overrides global module and process in WebStorm IDE.
Last v2 before restructuring the project to export an ECMAScript module by default.
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
Summary by CodeRabbit