Skip to content

refactor: Upgrade bcryptjs from 2.4.3 to 3.0.2 #9677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

parseplatformorg
Copy link
Contributor

@parseplatformorg parseplatformorg commented Mar 25, 2025

snyk-top-banner

Snyk has created this PR to upgrade bcryptjs from 2.4.3 to 3.0.2.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


⚠️ Warning: This PR contains major version upgrade(s), and may be a breaking change.

  • The recommended version is 3 versions ahead of your current version.

  • The recommended version was released a month ago.

Release notes
Package name: bcryptjs
  • 3.0.2 - 2025-02-18

    Bug fixes

    • Use upstream fix to emit interop helpers (28e5103)
  • 3.0.1 - 2025-02-17

    Bug fixes

    • Separate ESM and UMD type definitions (e7055ca)
  • 3.0.0 - 2025-02-13

    Breaking changes

    • Modernize project structure (2f45985)
      The project now exports an ECMAScript module by default, albeit with an UMD fallback, ships with types, the dist/ directory no longer exists in version control, and Closure Compiler externs have been removed.
    • Generate 2b hashes by default (d36bfb4)
      This library was not affected by the bug that led to incrementing the bcrypt version from 2a to 2b, but nowadays most implementations use 2b, including the native bcrypt binding, so this change aligns with them. Existing hashes will continue to work, but test logic that generates hashes and compares them literally might need to be updated to account for the new default.

    Features

    • Add helper to check for password input length (d5656b3)

    Other

    • Update publish workflow (2a9bea9)
    • Add note on using the ESM variant in the browser (e09eb9a)
    • Update types (58333a1)
    • Merge lint and test workflows (2e3b176)
    • Fix tests (ec02e8a)
    • Update legacy fallback to handle crypto dependency (9db275f)
    • Update lint workflow title (ac70ac5)
    • Adapt crypto module usage for ESM environments (574d690)
    • Format with prettier (e746547)
    • Rename default branch to 'main' (548559d)
    • Update description to mention TypeScript support (4977df0)
    • Add stale action for issues and PRs (a84d4e4)
    • Fix typo (c8c9c01)
    • Fix Node.js version in CI (1b54cc4)

    Backlog from v2

    • Added externs to .npmignore (#124) (7e2e93a)
      The npm package does not need externs as it is needed only for closure compiler. Added it in .npmignore since bcryptjs overrides global module and process in WebStorm IDE.
    • Make sure the bin script uses LF (684fac6)
    • Post-merge; Clean up a bit (b09f7f2)
    • Improve safeStringCompare using xor (#77) (648482a)
    • Added bin entry (49a1d1a)
  • 2.4.3 - 2017-02-07

    Last v2 before restructuring the project to export an ECMAScript module by default.

from bcryptjs GitHub release notes

Important

  • Warning: This PR contains a major version upgrade, and may be a breaking change.
  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Summary by CodeRabbit

  • Chores
    • Updated the "bcryptjs" dependency to version 3.0.2.

Snyk has created this PR to upgrade bcryptjs from 2.4.3 to 3.0.2.

See this package in npm:
bcryptjs

See this project in Snyk:
https://app.snyk.io/org/acinader/project/21343059-02d9-4182-87d7-718a44b181ef?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title [Snyk] Upgrade bcryptjs from 2.4.3 to 3.0.2 refactor: Upgrade bcryptjs from 2.4.3 to 3.0.2 Mar 25, 2025
Copy link

🚀 Thanks for opening this pull request!

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (2f2a92a) to head (9b7f526).
Report is 23 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9677   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files         187      187           
  Lines       15066    15066           
=======================================
  Hits        14035    14035           
  Misses       1031     1031           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza merged commit 9d8d494 into alpha Apr 7, 2025
24 checks passed
@mtrezza mtrezza deleted the snyk-upgrade-655fc5a50e40056da3e25314038d19db branch April 7, 2025 16:12
@parseplatformorg
Copy link
Contributor Author

🎉 This change has been released in version 8.1.1-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 7, 2025
@parseplatformorg
Copy link
Contributor Author

🎉 This change has been released in version 8.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 1, 2025
Copy link

coderabbitai bot commented May 1, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The only change made was updating the version of the "bcryptjs" dependency in the package.json file from "2.4.3" to "3.0.2". No other dependencies or parts of the file were modified.

Changes

File Change Summary
package.json Updated "bcryptjs" dependency from 2.4.3 to 3.0.2

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f2a92a and 9b7f526.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants