Skip to content

Conversation

@cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented May 30, 2024

Pull Request

Issue

Docker images aren't building because necessary executables have been removed in dependency docker images.

Closes: #9130

Approach

Install necessary executables in the build stage of the parse-server image, similar to git in #5861 (see #8359 for more details about reasons for only having in build stage). This shouldn't change the size of the release image.

Tasks

  • Ensure Docker build passes in CI

Signed-off-by: Corey <coreyearleon@icloud.com>
@parse-github-assistant
Copy link

parse-github-assistant bot commented May 30, 2024

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (0a054e6) to head (6d00138).
Report is 1 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9141   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files         186      186           
  Lines       14726    14726           
=======================================
+ Hits        13865    13866    +1     
+ Misses        861      860    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 closed this May 30, 2024
@cbaker6 cbaker6 reopened this May 30, 2024
@cbaker6
Copy link
Contributor Author

cbaker6 commented May 30, 2024

@mtrezza this is ready for review

Signed-off-by: Corey <coreyearleon@icloud.com>
@mtrezza mtrezza changed the title fix: Build docker images using node:lts-alpine ci: Fix docker image fails build May 30, 2024
@mtrezza mtrezza merged commit 6184185 into parse-community:alpha May 30, 2024
@cbaker6 cbaker6 deleted the patch-2 branch May 30, 2024 16:41
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.10

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 11, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 30, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker build is failing

3 participants