Conversation
Contributor
|
The role is expected to have a relation to users in the schema, mind to add the same test with a random object, and non existing relation key? |
Contributor
|
I agree with @flovilmart, I don't think the test you added actually tests this change. That said, it's also a simple change so I'd say feel free to merge anyway. (test failure is just flakiness) |
Contributor
Author
|
The test fails without the change, so it does work.. |
Current coverage is
|
Contributor
|
Actually that does make sense, since the relation will only be in the _SCHEMA object, the collection won't actually be created. |
Contributor
|
oh right ! |
gfosco
added a commit
that referenced
this pull request
Mar 6, 2016
Fix for related query on non-existing column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will finally address #280 and #286.