-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for related query on non-existing column #861
Conversation
The role is expected to have a relation to users in the schema, mind to add the same test with a random object, and non existing relation key? |
I agree with @flovilmart, I don't think the test you added actually tests this change. That said, it's also a simple change so I'd say feel free to merge anyway. (test failure is just flakiness) |
The test fails without the change, so it does work.. |
Current coverage is
|
Actually that does make sense, since the relation will only be in the _SCHEMA object, the collection won't actually be created. |
oh right ! |
Fix for related query on non-existing column
This will finally address #280 and #286.