Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Sep 14, 2021

New Pull Request Checklist

Issue Description

Currently it is possible that a dependency of parse server requires a higher node engine than parse server itself. This has the potential to break parse server, while passing the CI.

Related issue: #n/a

Approach

Add node engine CI check

TODOs before merging

  • Add entry to changelog

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 14, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #7574 (f53a52f) into master (3e4d1ec) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f53a52f differs from pull request most recent head 58aab21. Consider uploading reports for the commit 58aab21 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7574      +/-   ##
==========================================
- Coverage   93.93%   93.90%   -0.03%     
==========================================
  Files         181      181              
  Lines       13281    13281              
==========================================
- Hits        12475    12472       -3     
- Misses        806      809       +3     
Impacted Files Coverage Δ
src/RestWrite.js 93.63% <0.00%> (-0.48%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.25% <0.00%> (-0.22%) ⬇️
src/ParseServerRESTController.js 98.50% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4d1ec...58aab21. Read the comment docs.

@mtrezza mtrezza merged commit e9e3be1 into parse-community:master Sep 14, 2021
@mtrezza mtrezza deleted the ci-add-node-engine-check branch September 14, 2021 14:30
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants