Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Sep 3, 2021

New Pull Request Checklist

Issue Description

The _Session field restricted for the feature of restricted sessions is not in use by Parse Server internally. It is a code artifact of a feature that according to comments has not been ported from Parse.com to Open Source Parse Server.

This is a Parse Server internal field without any internal logic attached to it. The field is unlikely to be used by developers, so instead of deprecating it, we'll remove the field as a sudden breaking change with Parse Server 5.0. If a developer was using the field, the change for a developer would simply be setting the field false in the Session.beforeSave trigger.

See

Related issue: 6612

Approach

  • Remove _Session field restricted from schema
  • Remove logic that sets restricted to false by default when creating a new session

TODOs before merging

@mtrezza mtrezza changed the title fix: remove restricted session artifacts refactor: deprecate restricted session field Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #7543 (9ceb39b) into master (2783245) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 9ceb39b differs from pull request most recent head 7a2efc2. Consider uploading reports for the commit 7a2efc2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7543      +/-   ##
==========================================
- Coverage   93.96%   93.93%   -0.03%     
==========================================
  Files         181      181              
  Lines       13279    13279              
==========================================
- Hits        12477    12474       -3     
- Misses        802      805       +3     
Impacted Files Coverage Δ
src/Controllers/SchemaController.js 97.35% <ø> (ø)
src/RestWrite.js 94.10% <ø> (ø)
src/ParseServerRESTController.js 97.01% <0.00%> (-1.50%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.47% <0.00%> (-0.65%) ⬇️
src/batch.js 93.10% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2783245...7a2efc2. Read the comment docs.

@mtrezza mtrezza changed the title refactor: deprecate restricted session field refactor: remove restricted session field Sep 3, 2021
@mtrezza mtrezza merged commit 24188a3 into parse-community:master Sep 4, 2021
@mtrezza mtrezza removed the request for review from dplewis September 4, 2021 01:06
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants