-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Node.js 15.13.0 in CI #7312
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7312 +/- ##
==========================================
- Coverage 93.92% 93.89% -0.04%
==========================================
Files 181 181
Lines 13190 13190
==========================================
- Hits 12389 12385 -4
- Misses 801 805 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Can you please change the CI timeout from 15 to 20 to make the postgres check pass? It's in the CI.yaml, check-postgres, timeout-minutes: 15 |
I made a commit, from my phone, did it come out right? |
Yes, but could you try with 30mins? Not sure if it's just the test needing more time or a faulty test. |
@dplewis Does this only affect one Postgres test, or all Postgres tests? |
Its flaky so random but 14/15 passing test suites is passing to me |
Okay, so we'll set the timeout back to 15 and just re-run until it passes, I guess, thanks for clearing this up.
|
* Use Node.js 15.13.0 in CI * CI: Allow check-postgres 20 timeout * CI: 30 min timeout for check-postgres * reverted postgres timeout to 15 Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com>
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
This fixes a warning in the CI Self-Check
Approach
Followed an old update to the CI and imitated it.