Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump mongodb version in CI #7272

Merged
merged 5 commits into from
Mar 17, 2021

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Mar 16, 2021

bump mongodb version in CI

@mtrezza mtrezza changed the title bump mongodb version bump mongodb version in CI Mar 16, 2021
@mtrezza mtrezza requested a review from dplewis March 16, 2021 21:14
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #7272 (e1d4a03) into master (a02014f) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head e1d4a03 differs from pull request most recent head 04857e4. Consider uploading reports for the commit 04857e4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7272      +/-   ##
==========================================
- Coverage   93.89%   93.87%   -0.02%     
==========================================
  Files         179      179              
  Lines       13152    13152              
==========================================
- Hits        12349    12347       -2     
- Misses        803      805       +2     
Impacted Files Coverage Δ
src/Options/Definitions.js 100.00% <ø> (ø)
src/Options/index.js 100.00% <ø> (ø)
src/RestWrite.js 93.67% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02014f...04857e4. Read the comment docs.

@mtrezza mtrezza mentioned this pull request Mar 16, 2021
2 tasks
@mtrezza
Copy link
Member Author

mtrezza commented Mar 16, 2021

@dplewis Just checking whether you approve of the rewording of your changelog entry, I was able to condense it a bit:

  • Improved schema caching through database real-time hooks. Reduces DB queries, decreases Parse Query execution time and fixes a potential schema memory leak. If multiple Parse Server instances connect to the same DB (for example behind a load balancer), set the Parse Server Option databaseOptions.enableSchemaHooks: true to enable this feature and keep the schema in sync across all instances. Failing to do so will cause a schema change to not propagate to other instances and re-syncing will only happen when these instances restart. The options enableSingleSchemaCache and schemaCacheTTL have been removed. To use this feature with MongoDB, a replica set cluster with change stream support is required. (Diamond Lewis, SebC) #7214

Also, I added some of the information from the changelog to the Parse Server options docs:

Enables database real-time hooks to update single schema cache. Set to true if using multiple Parse Servers instances connected to the same database. Failing to do so will cause a schema change to not propagate to all instances and re-syncing will only happen when the instances restart. To use this feature with MongoDB, a replica set cluster with change stream support is required.

@dplewis
Copy link
Member

dplewis commented Mar 17, 2021

LGTM!

@mtrezza mtrezza closed this Mar 17, 2021
@mtrezza mtrezza reopened this Mar 17, 2021
@mtrezza mtrezza merged commit 637326d into parse-community:master Mar 17, 2021
@mtrezza mtrezza deleted the bump-mongodb-version branch March 17, 2021 01:01
Arul- pushed a commit to Arul-/parse-server that referenced this pull request Mar 25, 2021
* bump mongodb version

* improved wording in changelog

* another mongodb bump

* rewording changelog

* added info to option docs
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants