Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Facebook Limited Login #7219

Merged
merged 7 commits into from
Feb 24, 2021

Conversation

miguel-s
Copy link
Contributor

@miguel-s miguel-s commented Feb 23, 2021

Facebook recently introduced a new login path called Limited Login.

It prevents the user from being tracked by Facebook, but also does not grant access to Facebook's Graph API. The implementation is based on OpenID, similar to Apple's SignIn. You can find the docs here: Docs

How to use

Classic Graph API login (no change)

{
  id: "your_facebook_id",
  access_token: "facebook_graph_api_access_token"
}

Limited Login

{
  id: "your_facebook_id",
  token: "openid_token"
}

Note

The implementation of OpenID auth adapters is very similar and we might want to DRY it up e.g facebook limited and apple signin.

New Pull Request Checklist

TODOs before merging

  • Add test cases
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@miguel-s miguel-s changed the title Add support facebook limited Add support for Facebook Limited auth Feb 23, 2021
@miguel-s miguel-s changed the title Add support for Facebook Limited auth Add support for Facebook Limited Login Feb 23, 2021
@dplewis
Copy link
Member

dplewis commented Feb 23, 2021

Thanks for the PR. I didn't know about Limited Login. It looks good so far.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #7219 (098b37c) into master (91a0108) will increase coverage by 0.00%.
The diff coverage is 95.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7219   +/-   ##
=======================================
  Coverage   94.01%   94.02%           
=======================================
  Files         172      172           
  Lines       12873    12913   +40     
=======================================
+ Hits        12103    12141   +38     
- Misses        770      772    +2     
Impacted Files Coverage Δ
src/Adapters/Auth/facebook.js 92.06% <95.23%> (+5.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a0108...cc24ebf. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis dplewis marked this pull request as ready for review February 23, 2021 18:27
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just some cosmetic nits.

CHANGELOG.md Outdated Show resolved Hide resolved
spec/AuthenticationAdapters.spec.js Outdated Show resolved Hide resolved
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@mtrezza
Copy link
Member

mtrezza commented Feb 23, 2021

Could you just merge the current master into this branch for the checks to pass?

@miguel-s
Copy link
Contributor Author

@mtrezza Done :)

@mtrezza
Copy link
Member

mtrezza commented Feb 24, 2021

Thanks, I restarted the tests.

@dplewis dplewis merged commit 92f50f6 into parse-community:master Feb 24, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants