-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Facebook Limited Login #7219
Add support for Facebook Limited Login #7219
Conversation
Thanks for the PR. I didn't know about Limited Login. It looks good so far. |
Codecov Report
@@ Coverage Diff @@
## master #7219 +/- ##
=======================================
Coverage 94.01% 94.02%
=======================================
Files 172 172
Lines 12873 12913 +40
=======================================
+ Hits 12103 12141 +38
- Misses 770 772 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Just some cosmetic nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Could you just merge the current master into this branch for the checks to pass? |
@mtrezza Done :) |
Thanks, I restarted the tests. |
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
Facebook recently introduced a new login path called Limited Login.
It prevents the user from being tracked by Facebook, but also does not grant access to Facebook's Graph API. The implementation is based on OpenID, similar to Apple's SignIn. You can find the docs here: Docs
How to use
Classic Graph API login (no change)
Limited Login
Note
The implementation of OpenID auth adapters is very similar and we might want to DRY it up e.g facebook limited and apple signin.
New Pull Request Checklist
TODOs before merging