Skip to content

fix: Pass customObjectId in beforeSave #7167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dplewis merged 2 commits into from
Feb 12, 2021
Merged

fix: Pass customObjectId in beforeSave #7167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c926c51
beforeSave custom object id fix
mstniy Feb 6, 2021
c69f783
Added regression test case for issue #6733
mstniy Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions spec/CloudCode.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1779,6 +1779,39 @@ describe('beforeSave hooks', () => {
const myObject = new MyObject();
myObject.save().then(() => done());
});

it('should respect custom object ids (#6733)', async () => {
Parse.Cloud.beforeSave('TestObject', req => {
expect(req.object.id).toEqual('test_6733');
});

await reconfigureServer({ allowCustomObjectId: true });

const req = request({
// Parse JS SDK does not currently support custom object ids (see #1097), so we do a REST request
method: 'POST',
url: 'http://localhost:8378/1/classes/TestObject',
headers: {
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest',
},
body: {
objectId: 'test_6733',
foo: 'bar',
},
});

{
const res = await req;
expect(res.data.objectId).toEqual('test_6733');
}

const query = new Parse.Query('TestObject');
query.equalTo('objectId', 'test_6733');
const res = await query.find();
expect(res.length).toEqual(1);
expect(res[0].get('foo')).toEqual('bar');
});
});

describe('afterSave hooks', () => {
Expand Down
1 change: 1 addition & 0 deletions src/triggers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ export function getResponseObject(request, resolve, reject) {
response = {};
if (request.triggerName === Types.beforeSave) {
response['object'] = request.object._getSaveJSON();
response['object']['objectId'] = request.object.id;
Copy link

@felix-ht felix-ht Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to check config.allowCustomObjectId and to only set objectId if true

Copy link
Contributor Author

@mstniy mstniy Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need - RestWrite constructor takes care of that

Copy link
Contributor Author

@mstniy mstniy Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davimacedo How can I set custom object ids from javascript, given #1097 ?

Copy link
Contributor Author

@mstniy mstniy Feb 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davimacedo Test added

}
return resolve(response);
},
Expand Down