Fix schemaCacheTTL ParseServerOption is not working #7138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7138 +/- ##
==========================================
+ Coverage 93.90% 93.92% +0.02%
==========================================
Files 169 169
Lines 12535 12535
==========================================
+ Hits 11771 11774 +3
+ Misses 764 761 -3
Continue to review full report at Codecov.
|
Member
|
Can you write a test for when TTL expires? |
davimacedo
approved these changes
Jan 25, 2021
Member
davimacedo
left a comment
davimacedo
left a comment
There was a problem hiding this comment.
It looks good to me. @dplewis any other comment?
dplewis
approved these changes
Jan 25, 2021
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Jan 29, 2021
…7138) * Add Test case for checking SchemaCacheTTL * Fix schemaCacheTTL not working issue * Add Test case for TTL expires Co-authored-by: Roach Chang <roach.chang@aoitek.com>
Contributor
|
🎉 This change has been released in version 5.0.0-beta.1 |
Contributor
|
🎉 This change has been released in version 5.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
It seems
schemaCacheTTLParseServerOption is not working. It still follows cacheAdapter's setting.Related issue: closes #7119
Approach
Pass the schemaCacheTTL config to the cacheController while setting the schema cache.
TODOs before merging