Skip to content

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Dec 25, 2020

New Pull Request Checklist

Issue Description

Related issue: #7089

Approach

Helper function to send emails via attached mailAdapter. Usage:

Parse.Cloud.sendMail(data)

Mail data is dependent on the mail adapter.

TODOs before merging

@dblythy dblythy changed the title Send email via Parse.Cloud.sendEmail Send email via Parse.Cloud.sendMail Dec 25, 2020
@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #7096 (9266a06) into master (05f5aa0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7096      +/-   ##
==========================================
+ Coverage   93.63%   93.65%   +0.02%     
==========================================
  Files         169      169              
  Lines       12500    12508       +8     
==========================================
+ Hits        11704    11714      +10     
+ Misses        796      794       -2     
Impacted Files Coverage Δ
src/cloud-code/Parse.Cloud.js 98.73% <100.00%> (+0.14%) ⬆️
src/RestWrite.js 93.84% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f5aa0...9266a06. Read the comment docs.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks all good in this PR!

Could you just open a PR for the Cloud Code docs and add a small section for sending mail?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a renaming; apologies I didn't come across that earlier.

@dblythy dblythy changed the title Send email via Parse.Cloud.sendMail Send email via Parse.Cloud.sendEmail Dec 26, 2020
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, thanks for this PR!

@mtrezza mtrezza requested review from a team and mtrezza December 30, 2020 10:49
@dplewis dplewis merged commit d47891f into parse-community:master Dec 30, 2020
@dplewis dplewis deleted the SendEmail branch December 30, 2020 16:44
@mtrezza mtrezza mentioned this pull request Dec 30, 2020
3 tasks
@dblythy
Copy link
Member Author

dblythy commented Dec 31, 2020

I’ve just realised the change log says sendMail not sendEmail

dplewis pushed a commit that referenced this pull request Feb 21, 2021
* initial

* more tests

* Update CHANGELOG.md

* review

* log on error

* change logger to error

* rename

* Update Parse.Cloud.js
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants