Unify and cleanup cache.js. #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.cache
branch
2 times, most recently
from
099856b
to
0339f07
Compare
|
@nlutsenko updated the pull request. |
nlutsenko
force-pushed
the
nlutsenko.cache
branch
from
0339f07
to
5c6fce6
Compare
|
@nlutsenko updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Ehm, I am not sure on what happened here. Why request changes? What were the requested changes? |
…o through config.
nlutsenko
force-pushed
the
nlutsenko.cache
branch
from
5c6fce6
to
768a781
Compare
|
@nlutsenko updated the pull request. |
| @@ -142,11 +142,11 @@ function ParseServer({ | |||
| enableAnonymousUsers: enableAnonymousUsers, | |||
| allowClientClassCreation: allowClientClassCreation, | |||
| oauth: oauth | |||
| }; | |||
| }); | |||
There was a problem hiding this comment.
Use es6 style { masterKey, collectionPrefix...}
|
That was just for the test failures. I requested changes and was going to comment about the test failures, and only then noticed that you had already self-assigned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed usless methods, changed the api for it, unified all usages of it, added flow types, and most importantly removed database field on every request - everything goes through request.config.