Test transactions #6022
Merged
Test transactions #6022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Close #6019 |
Codecov Report
@@ Coverage Diff @@
## master #6022 +/- ##
==========================================
+ Coverage 93.77% 93.91% +0.14%
==========================================
Files 164 164
Lines 11096 11084 -12
==========================================
+ Hits 10405 10410 +5
+ Misses 691 674 -17
Continue to review full report at Codecov.
|
spec/MongoStorageAdapter.spec.js
Outdated
| expect(call.args[2].session).toBe(undefined); | ||
| }); | ||
| expect(found).toBe(true); | ||
| databaseAdapter.database.serverConfig.cursor.calls |
Contributor
There was a problem hiding this comment.
Including an assertion of the number of calls would be a good idea, since you're not using found.
Member
Author
There was a problem hiding this comment.
I am actually not sure that the other operations will be called. The right one is the one with the found. I added the others just in case.
Contributor
There was a problem hiding this comment.
I took the freedom to commit the separation of these tests. What do you think?
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* Test transactions * test: Separate transaction tests for SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.