Remove test delays #5579
Merged
Remove test delays #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…promise rejection
Codecov Report
@@ Coverage Diff @@
## master #5579 +/- ##
==========================================
- Coverage 94.05% 94.04% -0.01%
==========================================
Files 129 129
Lines 9214 9219 +5
==========================================
+ Hits 8666 8670 +4
- Misses 548 549 +1
Continue to review full report at Codecov.
|
acinader
approved these changes
May 11, 2019
spec/ParseLiveQueryServer.spec.js
Outdated
| serverStartComplete: () => { | ||
| expect(parseServer.liveQueryServer).not.toBeUndefined(); | ||
| expect(parseServer.liveQueryServer.server).toBe(parseServer.server); | ||
| parseServer.server.close(() => done()); |
There was a problem hiding this comment.
parseServer.server.close(done);
spec/ParseLiveQueryServer.spec.js
Outdated
| expect(parseServer.liveQueryServer.server).not.toBe( | ||
| parseServer.server | ||
| ); | ||
| parseServer.liveQueryServer.server.close(() => { |
There was a problem hiding this comment.
hm. maybe...
parseServer.liveQueryServer.server.close(parse.server.close.bind(done))
There was a problem hiding this comment.
just changed to parseServer.liveQueryServer.server.close(parseServer.server.close.bind(parseServer.server, done))
|
Ready to merge? |
|
Yes. I think it is. |
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* Changing __indexBuildCompletionCallbackForTests callback to serverStartComplete * Improving serverStartComplete callback to avoid production unhandled promise rejection * Add test to check inexistence of unhandled promise rejection on server fail * Removing some hooks delays * Removing delay after reconfigureServer * Improving code style
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the discussion on #5573 this PR removes some test delays.