⬆️ Bump winston and winston-daily-rotate-file #5244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot-preview
bot
added
the
dependencies
dependabot-preview
bot
force-pushed
the
dependabot/npm_and_yarn/winston-and-winston-daily-rotate-file
branch
5 times, most recently
from
39670a6 to
1c244b2
Compare
dependabot-preview
bot
force-pushed
the
dependabot/npm_and_yarn/winston-and-winston-daily-rotate-file
branch
2 times, most recently
from
b3b41e8 to
c5f9538
Compare
* ⚡ Release 3.1.3 * Update CHANGELOG.md
Bumps [winston](https://github.com/winstonjs/winston) and [winston-daily-rotate-file](https://github.com/winstonjs/winston-daily-rotate-file). These dependencies needed to be updated together. Updates `winston` from 2.4.4 to 3.1.0 - [Release notes](https://github.com/winstonjs/winston/releases) - [Changelog](https://github.com/winstonjs/winston/blob/master/CHANGELOG.md) - [Commits](winstonjs/winston@2.4.4...3.1.0) Updates `winston-daily-rotate-file` from 1.7.2 to 3.5.1 - [Release notes](https://github.com/winstonjs/winston-daily-rotate-file/releases) - [Commits](winstonjs/winston-daily-rotate-file@v1.7.2...v3.5.1) Signed-off-by: dependabot[bot] <support@dependabot.com>
dependabot-preview
bot
force-pushed
the
dependabot/npm_and_yarn/winston-and-winston-daily-rotate-file
branch
from
c5f9538 to
3ad1008
Compare
|
What's the status of this PR? When might this be merged/released? |
Contributor
|
@pixel2 did you need it for a particular reason? |
|
@flovilmart We want to use child loggers in winston 3, to better structure our logging. Realized there are some breaking changes in winston 3. I'm happy to contribute with a pull request fixing that? |
Contributor
|
Yep go ahead! |
|
Finished the PR for the Winston 3 migration, had to change more than I hoped to due to changes in how Winston handles transports (transports cannot be referenced by name anymore). Please come with feedback if the way I implemented it is not how you would have preferred it. |
Contributor
Author
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
dependabot-preview
bot
deleted the
dependabot/npm_and_yarn/winston-and-winston-daily-rotate-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps winston and winston-daily-rotate-file. These dependencies needed to be updated together.
Updates
winstonfrom 2.4.4 to 3.1.0Changelog
Sourced from winston's changelog.
Commits
9eda806[dist] Version bump. 3.1.080721e03.1.0 pre-release (#1444)5758752Update transports.md211483eAddresses issue 1446 and assigns transport name if given, or else retains the...bdb9f2bMention possibility to set log level for profiling (#1407)ba2fcaffix file rolling when tailing is set to true (#1420)908c300AddedisLevelEnabled(string)&isXXXEnabled()(#1352)a32aa3cdocs(README): Link objectMode and first use of info (#1400)10a270dlet keyword makes it scoped already (#1436)e41fe97Fix Profiler done() method typing (#1440)Updates
winston-daily-rotate-filefrom 1.7.2 to 3.5.1Commits
193a2183.5.1e9b1182fix types for usage with esModuleInterop0fdb94e3.5.0dc9404bupdate definition to export the interfaces along with classf1d1ff03.4.1b71d68aadd options property to typescript definitiond3f5de33.4.09770c46add ability to pass custom options to address #1843958b813.3.573ad255update to new file-stream-rotator version to fix #181Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge@dependabot reopenwill reopen this PR if it is closed@dependabot ignore this [patch|minor|major] versionwill close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard:
Finally, you can contact us by mentioning @dependabot.