Skip to content

Standardise null checking in PostgresStorageAdapter. #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2018
Merged

Standardise null checking in PostgresStorageAdapter. #5069

merged 1 commit into from
Sep 26, 2018

Conversation

@ben-eb
Copy link
Contributor

@ben-eb ben-eb commented Sep 20, 2018

Resolves #5065.

@ben-eb ben-eb mentioned this pull request Sep 20, 2018
Closed
@codecov
Copy link

codecov bot commented Sep 20, 2018 •
edited
Loading

Codecov Report

Merging #5069 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5069      +/-   ##
=========================================
- Coverage   93.71%   93.7%   -0.01%     
=========================================
  Files         123     123              
  Lines        8877    8879       +2     
=========================================
+ Hits         8319    8320       +1     
- Misses        558     559       +1
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.08% <66.66%> (-0.09%) ⬇️
src/RestWrite.js 93.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c024c1...891abb6. Read the comment docs.

flovilmart
flovilmart suggested changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the requested implementation, setting undefined should be ignored and a no-op on writes.

@ben-eb
Copy link
Contributor Author

ben-eb commented Sep 26, 2018

@flovilmart OK, updated.

@flovilmart flovilmart merged commit 45ff23b into parse-community:master Sep 26, 2018
@ben-eb ben-eb deleted the issue-5065 branch September 27, 2018 07:11
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@ben-eb @flovilmart
postgres: Ensure that setting a value to undefined is a no-op on writ…
a6044ba 
…es. (parse-community#5065) (parse-community#5069)
@snyk-bot snyk-bot mentioned this pull request May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@flovilmart flovilmart flovilmart approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ben-eb @flovilmart