Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allow Session triggers #4373

Closed
wants to merge 9 commits into from
Closed

[WIP] Allow Session triggers #4373

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
11b67c9
Allow Session triggers
addisonElliott Nov 23, 2017
36a304b
Merge branch 'master' into allow-session-triggers
addisonElliott Nov 23, 2017
ec94e33
Restore tests for validating _Session triggers and take not of this
addisonElliott Nov 25, 2017
83c7602
[WIP] Adding support for _Session class triggers
addisonElliott Nov 29, 2017
a277003
Merge branch 'master' into allow-session-triggers
addisonElliott Nov 30, 2017
2af1cfb
Altered buildUpdatedObjects to combine the extra data, original objec…
addisonElliott Nov 30, 2017
b00c05c
Fix issue with buildUpdatedObject function. Had to revert many of my …
addisonElliott Nov 30, 2017
35d216c
Merge branch 'master' of github.com:addisonElliott/parse-server into …
addisonElliott Dec 22, 2017
624c7cd
Merge branch 'master' into allow-session-triggers
addisonElliott Dec 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions spec/CloudCode.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1780,12 +1780,6 @@ describe('afterFind hooks', () => {
});

it('should validate triggers correctly', () => {
expect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this we should keep these, but check for a valid response rather than an exception. You can use .not.ToThrow() as seen just a bit below here.

Parse.Cloud.beforeSave('_Session', () => {});
}).toThrow('Triggers are not supported for _Session class.');
expect(() => {
Parse.Cloud.afterSave('_Session', () => {});
}).toThrow('Triggers are not supported for _Session class.');
expect(() => {
Parse.Cloud.beforeSave('_PushStatus', () => {});
}).toThrow('Only afterSave is allowed on _PushStatus');
Expand Down
4 changes: 0 additions & 4 deletions src/triggers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ const baseStore = function() {
};

function validateClassNameForTriggers(className, type) {
const restrictedClassNames = [ '_Session' ];
if (restrictedClassNames.indexOf(className) != -1) {
throw `Triggers are not supported for ${className} class.`;
}
if (type == Types.beforeSave && className === '_PushStatus') {
// _PushStatus uses undocumented nested key increment ops
// allowing beforeSave would mess up the objects big time
Expand Down