Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple include #426

Merged
merged 5 commits into from
Feb 17, 2016
Merged

fix multiple include #426

merged 5 commits into from
Feb 17, 2016

Conversation

mchun
Copy link

@mchun mchun commented Feb 15, 2016

When there are 2 or more include statements, if the current query does't contain keys in the first include field, then result will be returned before finding the rest of the include fields.

@flessard
Copy link
Contributor

+1

@@ -377,7 +377,11 @@ RestQuery.prototype.handleInclude = function() {
this.include = this.include.slice(1);
return this.handleInclude();
});
}else if(this.include.length >0){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the spacing here?

} else if (this.include.length > 0) {

@facebook-github-bot
Copy link

@mchun updated the pull request.

@facebook-github-bot
Copy link

@mchun updated the pull request.

@facebook-github-bot
Copy link

@mchun updated the pull request.

@drew-gross
Copy link
Contributor

Looks like a .DS_Store file snuck into your commit. Can you remove that, then squash into a single commit please?

@facebook-github-bot
Copy link

@mchun updated the pull request.

@mchun
Copy link
Author

mchun commented Feb 17, 2016

I am sorry for that. This is my first pull request ever and I am thrilled to have an opportunity to contribute.

@drew-gross
Copy link
Contributor

Cool, congrats on your first PR, and welcome to the open source community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants