fix(DatabaseController): Do not match searching for null in relation #3924
Conversation
| relatedIds | ||
| } | ||
| }); | ||
| const queries = query[key] == null ? |
There was a problem hiding this comment.
We should probably break that on more lines (as we do for the first early exit), quite tough to read.
There was a problem hiding this comment.
I improved little bit the code so it will handle more cases
|
Also, the issue still persists on postgres, can you address it please? |
Codecov Report
@@ Coverage Diff @@
## master #3924 +/- ##
==========================================
+ Coverage 90.51% 90.54% +0.02%
==========================================
Files 114 114
Lines 7686 7699 +13
==========================================
+ Hits 6957 6971 +14
+ Misses 729 728 -1
Continue to review full report at Codecov.
|
|
Fixed for Postgres. It was actually crashing when passing null values. Null values were not working even for simple queries (https://github.com/parse-community/parse-server/pull/3924/files#diff-f06f950a126bc6349f0e579b6ef362f7R26 and https://github.com/parse-community/parse-server/pull/3924/files#diff-f06f950a126bc6349f0e579b6ef362f7R52). There were some problems when creating the sql queries and also when saving null data (https://github.com/parse-community/parse-server/pull/3924/files#diff-b0af2ee2c26859a8aa6d8d0a0cf3a64aR779). |
spec/ParseQuery.spec.js
Outdated
| @@ -52,6 +106,9 @@ describe('Parse.Query testing', () => { | |||
|
|
|||
| var relDislike1 = cake1.relation("hater"); | |||
| relDislike1.add(user2); | |||
|
|
|||
| cake1.relation("something"); | |||
There was a problem hiding this comment.
Not needed. Jut removed.
| if (!t || t.type !== 'Relation') { | ||
| return Promise.resolve(query); | ||
| } | ||
| let queries = [{isNegation: false, relatedIds: []}]; |
There was a problem hiding this comment.
Why do we initialize non empties?
There was a problem hiding this comment.
It is the trick that solves the problem. When it is null and not match this (https://github.com/parse-community/parse-server/pull/3924/files#diff-26b0f888e8a20f22d9728a26272f6cddR624), we need to pass relatedIds empty, otherwise it will be ignored. I changed little bit the code. Take a look if it is more clear now.
…ll in relation field
|
Done. |
Fix #3923